[R]Fix LoadMonsterAreaInfo - ERROR

[Ken™]

The system can't load the right file in the source files. Actual file name should be "MonsterAreaInfo.txt" but the system tries to read regen.txt. Today, I wanna show how to fix this error completely.

Open GameLib/MapOutdoorLoad.cpp and find this function and replace with this.

bool CMapOutdoor::LoadMonsterAreaInfo()
{
	RemoveAllMonsterAreaInfo(); // Remove All Monster Info
	
	char szFileName[256];
	_snprintf(szFileName, sizeof(szFileName), "%s\\monsterareainfo.txt", GetMapDataDirectory().c_str());
	
	LPCVOID pModelData;
	CMappedFile File;
	
	if (!CEterPackManager::Instance().Get(File, szFileName, &pModelData)) return false;
	
	CMemoryTextFileLoader textFileLoader;
	CTokenVector stTokenVector;
	
	textFileLoader.Bind(File.Size(), pModelData);
	
	for (DWORD i = 0; i < textFileLoader.GetLineCount(); ++i)
	{
		if (!textFileLoader.SplitLine(i, &stTokenVector))
			continue;
		
		stl_lowers(stTokenVector[0]);
		
		// Start to read MonsterAreaInfo.txt
		if (0 == stTokenVector[0].compare("m") || 0 == stTokenVector[0].compare("g"))
		{
			if (stTokenVector.size() < 11)
			{
				TraceError("CMapOutdoorAccessor::LoadMonsterAreaInfo Get MonsterInfo File Format ERROR! continue....");
				continue;
			}

			CMonsterAreaInfo::EMonsterAreaInfoType eMonsterAreaInfoType;
			if (0 == stTokenVector[0].compare("m"))
			{
				eMonsterAreaInfoType = CMonsterAreaInfo::MONSTERAREAINFOTYPE_MONSTER;
			}
			else if (0 == stTokenVector[0].compare("g"))
			{
				eMonsterAreaInfoType = CMonsterAreaInfo::MONSTERAREAINFOTYPE_GROUP;
			}
			else
			{
				TraceError("CMapOutdoorAccessor::LoadMonsterAreaInfo Get MonsterInfo Data ERROR! continue....");
				continue;
			}
			
			const std::string & c_rstrOriginX	= stTokenVector[1].c_str();
			const std::string & c_rstrOriginY	= stTokenVector[2].c_str();
			const std::string & c_rstrSizeX		= stTokenVector[3].c_str();
			const std::string & c_rstrSizeY		= stTokenVector[4].c_str();
			const std::string & c_rstrZ			= stTokenVector[5].c_str();
			const std::string & c_rstrDir		= stTokenVector[6].c_str();
			const std::string & c_rstrTime		= stTokenVector[7].c_str();
			const std::string & c_rstrPercent	= stTokenVector[8].c_str();
			const std::string & c_rstrCount		= stTokenVector[9].c_str();
			const std::string & c_rstrVID		= stTokenVector[10].c_str();
			
			long lOriginX, lOriginY, lSizeX, lSizeY, lZ, lTime, lPercent;
			CMonsterAreaInfo::EMonsterDir eMonsterDir;
			DWORD dwMonsterCount;
			DWORD dwMonsterVID;
			
			lOriginX		= atol(c_rstrOriginX.c_str());
			lOriginY		= atol(c_rstrOriginY.c_str());
			lSizeX			= atol(c_rstrSizeX.c_str());
			lSizeY			= atol(c_rstrSizeY.c_str());
			lZ				= atol(c_rstrZ.c_str());
			eMonsterDir		= (CMonsterAreaInfo::EMonsterDir) atoi(c_rstrDir.c_str());
			lTime			= atol(c_rstrTime.c_str());
			lPercent		= atol(c_rstrPercent.c_str());
			dwMonsterCount	= (DWORD) atoi(c_rstrCount.c_str());
			dwMonsterVID	= (DWORD) atoi(c_rstrVID.c_str());
			
			CMonsterAreaInfo * pMonsterAreaInfo = AddMonsterAreaInfo(lOriginX, lOriginY, lSizeX, lSizeY);
			pMonsterAreaInfo->SetMonsterAreaInfoType(eMonsterAreaInfoType);
			if (CMonsterAreaInfo::MONSTERAREAINFOTYPE_MONSTER == eMonsterAreaInfoType)
				pMonsterAreaInfo->SetMonsterVID(dwMonsterVID);
			else if (CMonsterAreaInfo::MONSTERAREAINFOTYPE_GROUP == eMonsterAreaInfoType)
				pMonsterAreaInfo->SetMonsterGroupID(dwMonsterVID);
			pMonsterAreaInfo->SetMonsterCount(dwMonsterCount);
			pMonsterAreaInfo->SetMonsterDirection(eMonsterDir);
		}		
	}

	return true;
}

Kind Regards ~ Ken

[Cyber36]

Error	1	error C2039: 'size' : is not a member of 'CMappedFile'

in that line:

	textFileLoader.Bind(File.size(), pModelData);

Do you have a solution for that? ^^

[Claicon]

You downloaded it from which Site? Maybe the wrong file

[He3o Crysis]

Originally Posted by Cyber36

Error	1	error C2039: 'size' : is not a member of 'CMappedFile'

in that line:

	textFileLoader.Bind(File.size(), pModelData);

Do you have a solution for that? ^^

The "s" of size has to be uppercase.
Try

	textFileLoader.Bind(File.Size(), pModelData);

instead of

	textFileLoader.Bind(File.size(), pModelData);

Always be careful when you're randomly trying to use a method because size != Size

Regards,
Socialized

[Ken™]

Originally Posted by The_Epvp

You downloaded it from which Site? Maybe the wrong file

Maybe, you're wrong about your words? Try to google it

[Cyber36]

Originally Posted by Socialized

The "s" of size has to be uppercase.
Try

	textFileLoader.Bind(File.Size(), pModelData);

instead of

	textFileLoader.Bind(File.size(), pModelData);

Always be careful when you're randomly trying to use a method because size != Size

Regards,
Socialized

Thank you, that helped and i learned something

[.Aphrodite]

1>.\MapOutdoorLoad.cpp(450) : error C3861: 'RemoveAllMonsterInfo': identifier not found

There is no function for RemoveAllMonsterInfo

#Fixxed RemoveAllMonsterInfo(); -> RemoveAllMonsterAreaInfo();

[.J0ker]

Thanks

[fcsk_aim]

It's not a big deal that fix.
Someone with 10% brain can solve itself.

ThANKS ANYWAI

[naosou]

I still get that error in my syserr tho.

[lollo_9_1]

Someone told me on skype "I have this error: CMapOutdoor::Load - LoadMonsterAreaInfo ERROR; I applied this fix but nothing happened", I clicked the link he gave me and...

There are several things to say, but these few will suffice:

1. 
   
   Can you see? The WorldEditor reads regen.txt, not monsterareainfo.txt. Old map folders have these files, but those are totally useless, if not trash.
   
2. The regen.txt is just for the WorldEditor, not launcher. It's to develop ingame regens using the WE itself.
   We can care the less about LoadMonsterAreaInfo at all so much that we can simply wrap its call like this:
   

   #ifdef WORLD_EDITOR
   	if (!LoadMonsterAreaInfo())
   		TraceError("CMapOutdoor::Load - LoadMonsterAreaInfo ERROR");
   #endif

3. The MonsterAreaInfo feature is quite laggy, and buggy in the WorldEditor too.

Even if it's a 2015 thread, I'm still very astonished that you all fell for something so trivial.

[-Exploit]

Very usefull thanks Ken!

[Deadly2000]