Updated GWA2

[cortexio]

Originally Posted by ooklaba

anyone have an update for

 	_('CommandRequestQuoteSell:')
 	_('mov dword[TraderCostID],0')
 	_('mov dword[TraderCostValue],0')
 	_('push 0')
 	_('push 0')
 	_('push 0')
 	_('add eax,4')
 	_('push eax')
 	_('push 1')
 	_('push 0')
 	_('mov ecx,d')
 	_('xor edx,edx')
 	_('call RequestQuoteFunction')
 	_('ljmp CommandReturn')

 	_('CommandTraderSell:')
 	_('push 0')
 	_('push 0')
 	_('push 0')
 	_('push dword[TraderCostValue]')
 	_('push 0')
 	_('push TraderCostID')
 	_('push 1')
 	_('mov ecx,d')
 	_('xor edx,edx')
 	_('call TraderFunction')
 	_('mov dword[TraderCostID],0')
 	_('mov dword[TraderCostValue],0')
 	_('ljmp CommandReturn')

tyvm!

btw @

you want to make sure you have enough Sleep() between startsalvage() and materialsalvage(), and after materialsalvage(), or the client will overload (usually error = 007 and you are kicked out to character select pane)

if you get other than error = 007 (i.e. game crashing and prompts you with send report to anet) then in my experience it's something more serious which is wrong with the code

I have a fix for quote sell and trader sell.. but im not gonna post it here until im 100% happy with it. Maybe upcoming weekend ill work on it

[phat34]

Originally Posted by list comprehension

Something to point out is that tracing back the calling address of the sendpacket function will let you find and fix a lot of functions. There is a caveat though since gwa2 uses a pseudo assembler to turn asm instructions into raw byte code it must be supported in the assembler. So if there is an instruction needed that currently isn't there you will have to add it to that code portion of the assembler. Other non packet related functions can easily be found by finding a value used for it and then setting an on access check like cheat engine will let you do for example.This lets you find functions that don't directly lead to a packet such as getting an agent by name.

...a great solution to this delima which will save some advanced coders time was brought to light by cortexio, who has been killing it recently; is to add this to the compiler part of your gwa2!

Func _($AASM)
			Local $LBUFFER
			Select
				Case StringInStr($aASM, " -> ")
					Local $split = StringSplit($aASM, " -> ", 1)
					$lOpCode = StringReplace($split[2], " ", "")
					$mASMSize += 0.5 * StringLen($lOpCode)
					$mASMString &= $lOpCode
				Case StringRight($AASM, 1) = ":"
; continue function...

then you can add binary code directly in your ASM like so ->

Func CreateTraderHook()
			_('TraderHookProc:')
			_('mov ebx,dword[ebp+0xc] -> 8B 5D 0C')
			_('mov esi,eax')

my advice is to go back to your asm function when you have time and hard code your asm back in the long list, but while your testing or in your test code this can save you time!

[list comprehension]

Originally Posted by phat34

...a great solution to this delima which will save some advanced coders time was brought to light by cortexio, who has been killing it recently; is to add this to the compiler part of your gwa2!

Func _($AASM)
			Local $LBUFFER
			Select
				Case StringInStr($aASM, " -> ")
					Local $split = StringSplit($aASM, " -> ", 1)
					$lOpCode = StringReplace($split[2], " ", "")
					$mASMSize += 0.5 * StringLen($lOpCode)
					$mASMString &= $lOpCode
				Case StringRight($AASM, 1) = ":"
; continue function...

then you can add binary code directly in your ASM like so ->

Func CreateTraderHook()
			_('TraderHookProc:')
			_('mov ebx,dword[ebp+0xc] -> 8B 5D 0C')
			_('mov esi,eax')

my advice is to go back to your asm function when you have time and hard code your asm back in the long list, but while your testing or in your test code this can save you time!

That is a pretty good idea for gwa2 testing.

[maril15]

Just a simple header fix to move objects in bags :

Global Const $HEADER_ITEM_MOVE = 0x79

[cortexio]

How to fix request quote buying & selling.

First u need to a new case in "Func _($aASM)"

	Local $lBuffer
	Local $lOpCode
	Select
		Case StringInStr($aASM, " -> ")
			Local $split = StringSplit($aASM, " -> ", 1)
			$lOpCode = StringReplace($split[2], " ", "")
			$mASMSize += 0.5 * StringLen($lOpCode)
			$mASMString &= $lOpCode
		Case StringRight($aASM, 1) = ':'

Then replace the old code with the following

	$lTemp = GetScannedAddress('ScanTraderHook', -0x2F)
	SetValue('TraderHookStart', '0x' & Hex($lTemp, 8))
	SetValue('TraderHookReturn', '0x' & Hex($lTemp + 5, 8))

	SetValue('RequestQuoteFunction', '0x' & Hex(GetScannedAddress('ScanRequestQuoteFunction', 0x3B), 8)) ;-2
	SetValue('TraderFunction', '0x' & Hex(GetScannedAddress('ScanTraderFunction', -0x1E), 8))

	_('ScanRequestQuoteFunction:')
	AddPattern('83C4245B8BE55D')
	_('ScanTraderFunction:')
	AddPattern('83FF10761468AC210000')
	_('ScanTraderHook:')
	AddPattern('50516A466A06')

	_('CommandRequestQuote:')
	_('mov dword[TraderCostID],0')
	_('mov dword[TraderCostValue],0')
	_('mov esi,eax')
	_('add esi,4')
	_('push esi')
	_('push 1')
	_('push 0')
	_('push 0')
	_('push 0')
	_('push 0')
	_('push 0')
	_('push C')
	_('mov ecx,0')
	_('mov edx,2')
	_('call RequestQuoteFunction')
	_('add esp,20')
	_('ljmp CommandReturn')

	_('CommandRequestQuoteSell:')
	_('mov dword[TraderCostID],0')
	_('mov dword[TraderCostValue],0')
	_('push 0')
	_('push 0')
	_('push 0')
	_('add eax,4')
	_('push eax')
	_('push 1')
	_('push 0')
	_('push 0')
	_('push D')
	_('xor edx,edx')
	_('call RequestQuoteFunction')
	_('add esp,20')
	_('ljmp CommandReturn')

	_('CommandTraderBuy:')
	_('push 0')
	_('push TraderCostID')
	_('push 1')
	_('push 0')
	_('push 0')
	_('push 0')
	_('push 0')
	_('mov edx,dword[TraderCostValue]')
	_('push edx')
	_('push c')
	_('call TraderFunction')
	_('add esp,24')
	_('mov dword[TraderCostID],0')
	_('mov dword[TraderCostValue],0')
	_('ljmp CommandReturn')

 	_('CommandTraderSell:')
	_('push 0')
	_('push 0')
	_('push 0')
	_('push dword[TraderCostValue]')
	_('push 0')
	_('push TraderCostID')
	_('push 1')
	_('push 0')
	_('push D')
	_('mov ecx,d')
	_('xor edx,edx')
	_('call TraderFunction')
	_('add esp,24')
	_('mov dword[TraderCostID],0')
	_('mov dword[TraderCostValue],0')
	_('ljmp CommandReturn')



Func CreateTraderHook()
	_('TraderHookProc:')

    _('push eax')
	_('mov eax,dword[ebx+28] -> 8b 43 28')
	_('mov eax,[eax] -> 8b 00')
	_('mov dword[TraderCostID],eax')
	_('mov eax,dword[ebx+28] -> 8b 43 28')
	_('mov eax,[eax+4] -> 8b 40 04')
	_('mov dword[TraderCostValue],eax')
    _('pop eax')

	_('mov ebx,dword[ebp+C] -> 8B 5D 0C') ; Original bytes
	_('mov esi,eax') ; Original bytes

    _('push eax')
	_('mov eax,dword[TraderQuoteID]')
	_('inc eax')
	_('cmp eax,200')
	_('jnz TraderSkipReset')
	_('xor eax,eax')
	_('TraderSkipReset:')
	_('mov dword[TraderQuoteID],eax')
    _('pop eax')

	_('ljmp TraderHookReturn')
EndFunc   ;==>CreateTraderHook

It's possible that i forgot something in my post here. Try it, let me know if it works. Enjoy.

[NiliyaFlamme]

i have change this but gw window close instand if i try to srat bot with this changes

[cortexio]

Originally Posted by NiliyaFlamme

i have change this but gw window close instand if i try to srat bot with this changes

I just took a clean GWA2, made the changes, and it works.
So...

anyway, i usually dont do this, but here, my test file

[NiliyaFlamme]

Originally Posted by cortexio

I just took a clean GWA2, made the changes, and it works.
So...

anyway, i usually dont do this, but here, my test file

ty for your great job

[ooklaba]

thanks a lot Cortexio!

there were a few lines in the gwa_test you posted which were not in the post you made above, regardless, copying those into my gwa2 didn't change anything, it still crashed the game

i'll keep looking to see what i have missing

thank you very much for this

EDIT

add these lines to fix the crash happening

after scantraderhook, add

_('ScanSleep:')
	AddPattern('50516A466A06')

in createtraderhook(), at the end, add

 _('ljmp TraderHookReturn')

after commandtraderbuy, add

_('mov esi,eax')
	_('add esi,10') ;01239A20
	_('mov ecx,eax')
	_('add ecx,4')
	_('push ecx')
	_('mov edx,eax')
	_('add edx,8')
	_('push edx')
	_('push 1')
	_('push 0')
	_('push 0')
	_('push 0')
	_('push 0')
	_('mov eax,dword[eax+C]')
	_('push eax')
	_('push 1')
	_('call TransactionFunction')
	_('add esp,24')
	_('ljmp CommandReturn')

note - all this is cortexio's work, i'm just transcribing it

[cortexio]

Originally Posted by ooklaba

thanks a lot Cortexio!

there were a few lines in the gwa_test you posted which were not in the post you made above, regardless, copying those into my gwa2 didn't change anything, it still crashed the game

i'll keep looking to see what i have missing

thank you very much for this

EDIT

add these lines to fix the crash happening

after scantraderhook, add

_('ScanSleep:')
	AddPattern('50516A466A06')

in createtraderhook(), at the end, add

 _('ljmp TraderHookReturn')

after commandtraderbuy, add

_('mov esi,eax')
	_('add esi,10') ;01239A20
	_('mov ecx,eax')
	_('add ecx,4')
	_('push ecx')
	_('mov edx,eax')
	_('add edx,8')
	_('push edx')
	_('push 1')
	_('push 0')
	_('push 0')
	_('push 0')
	_('push 0')
	_('mov eax,dword[eax+C]')
	_('push eax')
	_('push 1')
	_('call TransactionFunction')
	_('add esp,24')
	_('ljmp CommandReturn')

note - all this is cortexio's work, i'm just transcribing it

literally none of that is needed... >_<

and

 _('ljmp TraderHookReturn')

was literally in my post...

[ooklaba]

 Spoiler

Originally Posted by cortexio

literally none of that is needed... >_<

and

 _('ljmp TraderHookReturn')

was literally in my post...

my bad, you're totally right, i must've missed it even though i copy pasted

thanks again man!

do you have a different function for tradererequestsell?
mine crashes the client.

Func TraderRequestSell($aItem)
	Local $lItemID
	Local $lFound = False
	Local $lQuoteID = MemoryRead($mTraderQuoteID)

	If IsDllStruct($aItem) = 0 Then
		$lItemID = $aItem
	Else
		$lItemID = DllStructGetData($aItem, 'ID')
	EndIf

	DllStructSetData($mRequestQuoteSell, 2, $lItemID)
	Enqueue($mRequestQuoteSellPtr, 8)

	Local $lDeadlock = TimerInit()
	Do
		Sleep(20)
		$lFound = MemoryRead($mTraderQuoteID) <> $lQuoteID
	Until $lFound Or TimerDiff($lDeadlock) > GetPing() + 5000
	Return $lFound
EndFunc   ;==>TraderRequestSell

[cortexio]

Originally Posted by ooklaba

 Spoiler

my bad, you're totally right, i must've missed it even though i copy pasted

thanks again man!

do you have a different function for tradererequestsell?
mine crashes the client.

Func TraderRequestSell($aItem)
	Local $lItemID
	Local $lFound = False
	Local $lQuoteID = MemoryRead($mTraderQuoteID)

	If IsDllStruct($aItem) = 0 Then
		$lItemID = $aItem
	Else
		$lItemID = DllStructGetData($aItem, 'ID')
	EndIf

	DllStructSetData($mRequestQuoteSell, 2, $lItemID)
	Enqueue($mRequestQuoteSellPtr, 8)

	Local $lDeadlock = TimerInit()
	Do
		Sleep(20)
		$lFound = MemoryRead($mTraderQuoteID) <> $lQuoteID
	Until $lFound Or TimerDiff($lDeadlock) > GetPing() + 5000
	Return $lFound
EndFunc   ;==>TraderRequestSell

my function is the same

[ayyy_lmao]

header?

[phat34]

        $lTemp = GetScannedAddress('ScanRenderFunc', -0x67)
	SETVALUE("RenderingMod", "0x" & Hex($LTEMP, 8))
	SETVALUE("RenderingModReturn", "0x" & Hex($LTEMP + 10, 8))

        $MDISABLERENDERING = GETVALUE("DisableRendering")

	_("ScanRenderFunc:")
	ADDPATTERN("F6C401741C68B1010000BA")

	Func ENABLERENDERING()
		MEMORYWRITE($MDISABLERENDERING, 0)
	EndFunc
	FUNC DISABLERENDERING()
		IF MEMORYREAD(GETVALUE('DisableRendering')) THEN
			ENABLERENDERING()
		ELSE
			MEMORYWRITE($MDISABLERENDERING, 1)
		ENDIF
	ENDFUNC

;iN FUNC MODIFYMEMORY()

        CREATERENDERINGMOD()
        WRITEDETOUR("RenderingMod", "RenderingModProc")

;iN CREATEDATA under  _("TraderCostValue/4")

	_("DisableRendering/4")

;lAST BUT NOT LEAST

	Func CREATERENDERINGMOD()
		_("RenderingModProc:")
		_("add esp,4")
		_("cmp dword[DisableRendering],1")
		_("ljmp RenderingModReturn")
	EndFunc

[logicdoor]

Originally Posted by cortexio

I just took a clean GWA2, made the changes, and it works.
So...

anyway, i usually dont do this, but here, my test file

Since you mentioned some headers in your file were old, I have updated them here - had some issues with abandon quest and use item, so just in case someone has been using your header file and is having issues:

#Region Headers
;=QUEST=
Global Const $HEADER_QUEST_ACCEPT				= 0x42	;Accepts a quest from the NPC
Global Const $HEADER_QUEST_REWARD				= 0x42	;Retrieves Quest reward from NPC
Global Const $HEADER_QUEST_ABANDON				= 0x13	 ;Abandons the quest

;=HERO=
Global Const $HEADER_HERO_AGGRESSION			= 0x18	;Sets the heroes aggression level
Global Const $HEADER_HERO_LOCK					= 0x1A	;Locks the heroes target
Global Const $HEADER_HERO_TOGGLE_SKILL			= 0x1B	;Enables or disables the heroes skill
Global Const $HEADER_HERO_CLEAR_FLAG			= 0x1D	;Clears the heroes position flag
Global Const $HEADER_HERO_PLACE_FLAG			= 0x1D	;Sets the heroes position flag, hero runs to position
Global Const $HEADER_HERO_ADD					= 0x21	;Adds hero to party
Global Const $HEADER_HERO_KICK					= 0x22	;Kicks hero from party
Global Const $HEADER_HEROES_KICK				= 0x22	;Kicks ALL heroes from party

;=PARTY=
Global Const $HEADER_PARTY_PLACE_FLAG			= 0x1E	;Sets the party position flag, all party-npcs runs to position
Global Const $HEADER_PARTY_CLEAR_FLAG			= 0x1E	;Clears the party position flag
Global Const $HEADER_HENCHMAN_ADD				= 0xA7	;Adds henchman to party
Global Const $HEADER_PARTY_LEAVE				= 0xAA	;Leaves the party
Global Const $HEADER_HENCHMAN_KICK				= 0x80	;Kicks a henchman from party
Global Const $HEADER_INVITE_TARGET				= 0xA6	;Invite target player to party
Global Const $HEADER_INVITE_CANCEL				= 0xA3	;Cancel invitation of player
Global Const $HEADER_INVITE_ACCEPT				= 0xA2	;Accept invitation to party

;=TARGET (Enemies or NPC)=
Global Const $HEADER_CALL_TARGET				= 0x26	;Calls the target without attacking (Ctrl+Shift+Space)
Global Const $HEADER_ATTACK_AGENT				= 0x2D	;Attacks agent (Space IIRC)
Global Const $HEADER_CANCEL_ACTION				= 0x2F	;Cancels the current action
Global Const $HEADER_AGENT_FOLLOW				= 0x39	;Follows the agent/npc. Ctrl+Click triggers "I am following Person" in chat
Global Const $HEADER_NPC_TALK					= 0x40	;talks/goes to npc
Global Const $HEADER_SIGNPOST_RUN				= 0x58	;Runs to signpost

;=DROP=
Global Const $HEADER_ITEM_DROP					= 0x33	;Drops item from inventory to ground
Global Const $HEADER_GOLD_DROP					= 0x36	;Drops gold from inventory to ground

;=BUFFS=
Global Const $HEADER_STOP_MAINTAIN_ENCH			= 0x30	;Drops buff, cancel enchantmant, whatever you call it

;=ITEMS=
Global Const $HEADER_ITEM_EQUIP					= 0x37	;Equips item from inventory/chest/no idea
Global Const $HEADER_ITEM_PICKUP				= 0x46	;Picks up an item from ground
Global Const $HEADER_ITEM_DESTROY				= 0x70	 ;Destroys the item
Global Const $HEADER_ITEM_ID					= 0x73	;Identifies item in inventory
Global Const $HEADER_ITEM_MOVE					= 0x79	;Moves item in inventory
Global Const $HEADER_ITEMS_ACCEPT_UNCLAIMED		= 0x7A	;Accepts ITEMS not picked up in missions
Global Const $HEADER_ITEM_MOVE_EX				= 0x7A	;Moves an item, with amount to be moved.
Global Const $HEADER_SALVAGE_MATS				= 0x81	;Salvages materials from item
Global Const $HEADER_SALVAGE_MODS				= 0x82	;Salvages mods from item
Global Const $HEADER_ITEM_USE					= 0x85	;Uses item from inventory/chest
Global Const $HEADER_ITEM_UNEQUIP				= 0x55	;Unequip item
Global Const $HEADER_UPGRADE					= 0x85	;used by gwapi. is it even useful? NOT TESTED
Global Const $HEADER_UPGRADE_ARMOR_1			= 0x85	;used by gwapi. is it even useful? NOT TESTED
Global Const $HEADER_UPGRADE_ARMOR_2			= 0x88	;used by gwapi. is it even useful? NOT TESTED

;=TRADE=
Global Const $HEADER_TRADE_PLAYER				= 0x50	;Send trade request to player
Global Const $HEADER_TRADE_OFFER_ITEM			= 0x02	;Add item to trade window
Global Const $HEADER_TRADE_SUBMIT_OFFER			= 0x03	;Submit offer
Global Const $HEADER_TRADE_CHANGE_OFFER			= 0x06	;Change offer
Global Const $HEADER_TRADE_CANCEL				= 0x01	;Cancel trade
Global Const $HEADER_TRADE_ACCEPT				= 0x07	;Accept trade

;=TRAVEL=
Global Const $HEADER_MAP_TRAVEL					= 0xB9	;Travels to outpost via worldmap
Global Const $HEADER_GUILDHALL_TRAVEL			= 0xB8	;Travels to guild hall
Global Const $HEADER_GUILDHALL_LEAVE			= 0xBA	;Leaves Guildhall

;=FACTION=
Global Const $HEADER_FACTION_DONATE				= 0x3C	;Donates kurzick/luxon faction to ally

;=TITLE=
Global Const $HEADER_TITLE_DISPLAY				= 0x5F	;Displays title (from Gigis Vaettir Bot)
Global Const $HEADER_TITLE_CLEAR				= 0x60	;Hides title (from Gigis Vaettir Bot)

;=DIALOG=
Global Const $HEADER_DIALOG						= 0x42	;Sends a dialog to NPC
Global Const $HEADER_CINEMATIC_SKIP				= 0x6A	;Skips the cinematic

;=SKILL / BUILD=
Global Const $HEADER_SET_SKILLBAR_SKILL			= 0x63	;Changes a skill on the skillbar
Global Const $HEADER_LOAD_SKILLBAR				= 0x64	;Loads a complete skillbar
Global Const $HEADER_CHANGE_SECONDARY			= 0x48	;Changes Secondary class (from Build window, not class changer)
Global Const $HEADER_SKILL_USE_ALLY				= 0x4D	;used by gwapi. appears to have changed
Global Const $HEADER_SKILL_USE_FOE				= 0x4D	;used by gwapi. appears to have changed
Global Const $HEADER_SKILL_USE_ID				= 0x4D	;
Global Const $HEADER_USE_SKILL					= 0x4D
Global Const $HEADER_SET_ATTRIBUTES				= 0x11	;hidden in init stuff like sendchat
Global Const $HEADER_OPEN_SKILLS				= 0x42

;=CHEST=
Global Const $HEADER_CHEST_OPEN					= 0x5A	;Opens a chest (with key AFAIK)
Global Const $HEADER_CHANGE_GOLD				= 0x83	;Moves Gold (from chest to inventory, and otherway around IIRC)

;=MISSION=
Global Const $HEADER_MODE_SWITCH				= 0xA3	;Toggles hard- and normal mode
Global Const $HEADER_MISSION_ENTER				= 0xAD	;Enter a mission/challenge
Global Const $HEADER_MISSION_FOREIGN_ENTER		= 0xAD	;Enters a foreign mission/challenge (no idea honestly)
Global Const $HEADER_OUTPOST_RETURN				= 0xAF	;Returns to outpost after /resign

;=CHAT=
Global Const $HEADER_SEND_CHAT					= 0x6B	;Needed for sending messages in chat

;=OTHER CONSTANTS=
Global Const $HEADER_MAX_ATTRIBUTES_CONST_5		= 0x04	;constant at word 5 of max attrib packet. Changed from 3 to four in most recent update
Global Const $HEADER_MAX_ATTRIBUTES_CONST_22	= 0x04	;constant at word 22 of max attrib packet. Changed from 3 to four in most recent update
Global Const $HEADER_GO_PLAYER					= 0x3A
Global Const $HEADER_OPEN_GB_WINDOW				= 0xA0
Global Const $HEADER_CLOSE_GB_WINDOW			= 0xA1
Global Const $HEADER_START_RATING_GVG			= 0xAA
Global Const $HEADER_EQUIP_BAG					= 0x37
Global Const $HEADER_HOM_DIALOG					= 0x5A
Global Const $HEADER_PROFESSION_ULOCK			= 0x42

#EndRegion Headers